Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab-bar-mode support #138

Open
isamert opened this issue Nov 15, 2020 · 3 comments
Open

tab-bar-mode support #138

isamert opened this issue Nov 15, 2020 · 3 comments

Comments

@isamert
Copy link

isamert commented Nov 15, 2020

I saw that it's mentioned in the README but I would like to know if there is any progress or what do you have in your mind generally. I would also like to contribute for getting this feature if you can give me a few starting points.

@gcv
Copy link
Collaborator

gcv commented Nov 16, 2020

Cool!

I was actually thinking about that last night, and I think the way Bufler handles tab-bar-mode makes a lot of sense (look at bufler-workspace-tabs.el):

  • make a separate minor mode for it, persp-tabs-mode or another good name — that way it's opt-in for people who (1) don't want it, or (2) use an older version of Emacs
  • advise tab-bar-* functions as needed with :override (not sure how many you need to treat that way; also, please use the new advice system — Perspective uses the old system in several places, but there's no reason to do so for a brand-new feature which relies on Emacs 27 anyway)
  • it feels like it shouldn't be a ton of new code to get working (I haven't studied tab-bar-mode very closely, so not sure about that side of it, but Perspective itself has plenty of helper functions), so I think it can all fit in the current perspective.el source file

I'm pressed for time right now, so by all means give it a try if you want! It's great to have more people familiar with the Perspective code.

@LemonBreezes
Copy link

Hey, I have been using the snippet of code from this comment for a few weeks successfully: Bad-ptr/persp-mode.el#122 (comment).

@gcv
Copy link
Collaborator

gcv commented Aug 28, 2022

@LemonBreezes: That code wouldn't work directly in Perspective, which has different hooks and parameter setting from persp-mode. Did you adapt it? If so, please post the changes you made. I'd like to give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants