fix(providers): update providers config from verification walk-throug…

…hs (#10582) * fix(netlify): add "?scope" query param to authorizationUrl * fix(slack): update checks * fix(workos): add connection name to authorizationUrl * fix: cleanup providers in example app and workos docs * chore: update example connection
nextauthjs · Apr 14, 2024 · 85ab5fa · 85ab5fa
1 parent 10b4de9
commit 85ab5fa
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 11 deletions.
diff --git a/apps/examples/nextjs/auth.ts b/apps/examples/nextjs/auth.ts
@@ -55,17 +55,17 @@ export const config = {
     Hubspot,
     Keycloak,
     LinkedIn,
-    Netlify({ authorization: "https://app.netlify.com/authorize?scope" }),
+    Netlify,
     Okta,
     Passage,
     Pinterest,
     Reddit,
-    Slack({ checks: ["nonce"] }), // TODO: Make this default in core
+    Slack,
     Spotify,
     Twitch,
     Twitter,
     WorkOS({
-      authorization: `https://api.workos.com/sso/authorize?${new URLSearchParams({ connection: process.env.AUTH_WORKOS_CONNECTION ?? "" })}`,
+      connection: process.env.AUTH_WORKOS_CONNECTION,
     }),
     Zoom,
   ],

diff --git a/docs/pages/getting-started/providers/workos.mdx b/docs/pages/getting-started/providers/workos.mdx
@@ -35,9 +35,10 @@ https://example.com/auth/callback/workos
 ```
 AUTH_WORKOS_ID
 AUTH_WORKOS_SECRET
-AUTH_WORKOS_ISSUER
 ```
 
+WorkOS also requires you to pass in your `connection` ID to the provider.
+
 ### Configuration
 
 <Code>
@@ -48,7 +49,7 @@ import NextAuth from "next-auth"
 import WorkOS from "next-auth/providers/workos"
 
 export const { handlers, auth, signIn, signOut } = NextAuth({
-  providers: [WorkOS],
+  providers: [WorkOS({ connection: "conn_abc123" })],
 })
 ```
 
@@ -60,7 +61,7 @@ import { SvelteKitAuth } from "@auth/sveltekit"
 import WorkOS from "@auth/sveltekit/providers/workos"
 
 export const { handle, signIn, signOut } = SvelteKitAuth({
-  providers: [WorkOS],
+  providers: [WorkOS({ connection: "conn_abc123" })],
 })
 ```
 
@@ -71,7 +72,10 @@ export const { handle, signIn, signOut } = SvelteKitAuth({
 import { ExpressAuth } from "@auth/express"
 import WorkOS from "@auth/express/providers/workos"
 
-app.use("/auth/*", ExpressAuth({ providers: [WorkOS] }))
+app.use(
+  "/auth/*",
+  ExpressAuth({ providers: [WorkOS({ connection: "conn_abc123" })] })
+)
 ```
 
   </Code.Express>

diff --git a/packages/core/src/providers/netlify.ts b/packages/core/src/providers/netlify.ts
@@ -66,7 +66,7 @@ export default function Netlify(
     id: "netlify",
     name: "Netlify",
     type: "oauth",
-    authorization: "https://app.netlify.com/authorize",
+    authorization: "https://app.netlify.com/authorize?scope",
     token: "https://api.netlify.com/oauth/token",
     userinfo: "https://api.netlify.com/api/v1/user",
     profile(profile) {

diff --git a/packages/core/src/providers/slack.ts b/packages/core/src/providers/slack.ts
@@ -106,6 +106,7 @@ export default function Slack<P extends SlackProfile>(
     name: "Slack",
     type: "oidc",
     issuer: "https://slack.com",
+    checks: ["nonce"],
     style: { brandColor: "#611f69" },
     options,
   }

diff --git a/packages/core/src/providers/workos.ts b/packages/core/src/providers/workos.ts
@@ -144,15 +144,17 @@ export interface WorkOSProfile extends Record<string, any> {
  * :::
  */
 export default function WorkOS<P extends WorkOSProfile>(
-  options: OAuthUserConfig<P>
+  options: OAuthUserConfig<P> & { connection: string }
 ): OAuthConfig<P> {
-  const { issuer = "https://api.workos.com/" } = options
+  const { issuer = "https://api.workos.com/", connection = "" } = options
+
+  const connectionParams = new URLSearchParams({ connection })
 
   return {
     id: "workos",
     name: "WorkOS",
     type: "oauth",
-    authorization: `${issuer}sso/authorize`,
+    authorization: `${issuer}sso/authorize?${connectionParams}`,
     token: `${issuer}sso/token`,
     client: {
       token_endpoint_auth_method: "client_secret_post",