Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export CredentialsSignin class to extend in custom authorize errors #10200

Merged
merged 4 commits into from Mar 4, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Mar 3, 2024

☕️ Reasoning

  • Extending feat: customizable authorize() error #9871
  • Explicitly shows throwing the custom error in the Credentials provider docs
  • Exports the CredentialsSignin class you're meant to extend from each framework package, to avoid having to install @auth/core just for this.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2024 4:43pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 4:43pm
nextra-docs ⬜️ Ignored (Inspect) Visit Preview Mar 4, 2024 4:43pm

@ndom91 ndom91 changed the title fix(docs): show throwing custom error in credentials docs fix: export CredentialsSignin class to extend in custom authorize errors Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 39.29%. Comparing base (0168f3c) to head (9a78395).

Files Patch % Lines
packages/frameworks-solid-start/src/index.ts 0.00% 9 Missing ⚠️
packages/frameworks-sveltekit/src/lib/index.ts 0.00% 2 Missing ⚠️
packages/next-auth/src/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10200      +/-   ##
==========================================
- Coverage   39.30%   39.29%   -0.01%     
==========================================
  Files         171      171              
  Lines       27242    27256      +14     
  Branches     1151     1151              
==========================================
+ Hits        10708    10711       +3     
- Misses      16534    16545      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 merged commit 9f97d1b into main Mar 4, 2024
9 of 10 checks passed
@ndom91 ndom91 deleted the ndom91/custom-authorize-error-cleanup branch March 4, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants