Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jsdoc): note different default basePaths #10239

Merged
merged 3 commits into from Mar 14, 2024

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Mar 7, 2024

☕️ Reasoning

  • Clear up minor point of confusion in JSDoc regarding default basePath

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

@ndom91 ndom91 requested a review from ThangHuuVu as a code owner March 7, 2024 12:41
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 5:06pm
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 5:06pm
nextra-docs ⬜️ Ignored (Inspect) Visit Preview Mar 14, 2024 5:06pm

@github-actions github-actions bot added the core Refers to `@auth/core` label Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.63%. Comparing base (4a2d511) to head (9294f78).

❗ Current head 9294f78 differs from pull request most recent head 942fdfa. Consider uploading reports for the commit 942fdfa to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10239       +/-   ##
===========================================
+ Coverage   39.36%   61.63%   +22.26%     
===========================================
  Files         171      132       -39     
  Lines       27288     9862    -17426     
  Branches     1165      703      -462     
===========================================
- Hits        10742     6078     -4664     
+ Misses      16546     3784    -12762     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 merged commit e9a3e8e into main Mar 14, 2024
8 of 11 checks passed
@ndom91 ndom91 deleted the ndom91/fix-minor-jsdoc-copy-upadte branch March 14, 2024 17:01
JipSterk pushed a commit to JipSterk/next-auth that referenced this pull request Apr 3, 2024
JipSterk pushed a commit to JipSterk/next-auth that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant