Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): fix failed tests for webauthn #10281

Merged
merged 1 commit into from Mar 11, 2024
Merged

Conversation

ThangHuuVu
Copy link
Member

@ThangHuuVu ThangHuuVu commented Mar 11, 2024

Some tests are failing after we change the error message format in #10186
Most of the changes are prettier. I just change some dots in assertion messages.

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated (UTC)
auth-docs ⬜️ Ignored (Inspect) Mar 11, 2024 2:13pm
next-auth-docs ⬜️ Ignored (Inspect) Mar 11, 2024 2:13pm
nextra-docs ⬜️ Ignored (Inspect) Mar 11, 2024 2:13pm

@ThangHuuVu ThangHuuVu requested a review from ndom91 March 11, 2024 14:13
@github-actions github-actions bot added the core Refers to `@auth/core` label Mar 11, 2024
Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.29%. Comparing base (6cd0fe8) to head (d933d67).

Additional details and impacted files
@@             Coverage Diff             @@
##             main   #10281       +/-   ##
===========================================
- Coverage   62.67%   39.29%   -23.39%     
===========================================
  Files          49      171      +122     
  Lines        9697    27260    +17563     
  Branches      620     1160      +540     
===========================================
+ Hits         6078    10712     +4634     
- Misses       3619    16548    +12929     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ThangHuuVu ThangHuuVu merged commit 9a5416b into main Mar 11, 2024
13 of 15 checks passed
@ThangHuuVu ThangHuuVu deleted the fix/core-tests-webauthn branch March 11, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant