Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(providers): make webex apiBaseUrl optional #10354

Merged
merged 2 commits into from Apr 6, 2024

Conversation

askmrsinh
Copy link
Contributor

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Mar 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 2:02am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Apr 6, 2024 2:02am

Copy link

vercel bot commented Mar 19, 2024

@askmrsinh is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 39.48%. Comparing base (8120fd4) to head (3ac4d64).

Files Patch % Lines
packages/core/src/providers/webex.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10354   +/-   ##
=======================================
  Coverage   39.48%   39.48%           
=======================================
  Files         171      171           
  Lines       27322    27322           
  Branches     1169     1169           
=======================================
  Hits        10787    10787           
  Misses      16535    16535           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@askmrsinh
Copy link
Contributor Author

@ndom91, @ThangHuuVu This is a small fix - please do let me know if anything's pending from my end.

@ThangHuuVu ThangHuuVu merged commit edc4fe4 into nextauthjs:main Apr 6, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants