Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): update azure-ad.ts #10448

Merged
merged 2 commits into from Mar 31, 2024
Merged

chore(docs): update azure-ad.ts #10448

merged 2 commits into from Mar 31, 2024

Conversation

Xorlent
Copy link
Contributor

@Xorlent Xorlent commented Mar 30, 2024

Added required API Permissions grant step for Azure AD/Entra SSO setup.

☕️ Reasoning

Azure AD/Entra SSO provider setup was missing the API Permissions granting step.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

📌 Resources

Added required API Permissions grant step for Azure AD/Entra SSO setup.
Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2024 0:34am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Mar 31, 2024 0:34am

Copy link

vercel bot commented Mar 30, 2024

@Xorlent is attempting to deploy a commit to the authjs Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 39.48%. Comparing base (246a838) to head (9bb5bdd).
Report is 1 commits behind head on main.

Files Patch % Lines
packages/core/src/providers/azure-ad.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10448      +/-   ##
==========================================
- Coverage   39.48%   39.48%   -0.01%     
==========================================
  Files         171      171              
  Lines       27321    27322       +1     
  Branches     1169     1169              
==========================================
  Hits        10787    10787              
- Misses      16534    16535       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91
Copy link
Member

ndom91 commented Mar 31, 2024

Awesome, thanks

@ndom91 ndom91 merged commit 8120fd4 into nextauthjs:main Mar 31, 2024
11 of 15 checks passed
@Xorlent Xorlent deleted the patch-3 branch March 31, 2024 21:57
JipSterk pushed a commit to JipSterk/next-auth that referenced this pull request Apr 3, 2024
Co-authored-by: Thang Vu <hi@thvu.dev>
JipSterk pushed a commit to JipSterk/next-auth that referenced this pull request Apr 3, 2024
Co-authored-by: Thang Vu <hi@thvu.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants