Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: infer providers logo filename #10496

Merged
merged 3 commits into from Apr 6, 2024
Merged

Conversation

ndom91
Copy link
Member

@ndom91 ndom91 commented Apr 6, 2024

☕️ Reasoning

  • Infer provider logo filenames ([providerId].svg) from our docs domain
  • Set sane defaults

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

📌 Resources

Copy link

vercel bot commented Apr 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments
Name Status Preview Updated (UTC)
auth-docs ⬜️ Ignored (Inspect) Apr 6, 2024 8:25pm
next-auth-docs ⬜️ Ignored (Inspect) Apr 6, 2024 8:25pm
nextra-docs ⬜️ Ignored (Inspect) Apr 6, 2024 8:25pm

@github-actions github-actions bot added providers core Refers to `@auth/core` labels Apr 6, 2024
Copy link

codecov bot commented Apr 6, 2024

Codecov Report

Attention: Patch coverage is 18.18182% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 39.51%. Comparing base (41295db) to head (cb019e5).
Report is 4 commits behind head on main.

Files Patch % Lines
packages/core/src/lib/pages/signin.tsx 44.44% 10 Missing ⚠️
packages/core/src/providers/zoom.ts 0.00% 4 Missing ⚠️
packages/core/src/providers/vk.ts 0.00% 3 Missing ⚠️
packages/core/src/providers/okta.ts 0.00% 2 Missing ⚠️
packages/core/src/providers/atlassian.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/azure-ad-b2c.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/azure-ad.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/battlenet.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/cognito.ts 0.00% 1 Missing ⚠️
packages/core/src/providers/discord.ts 0.00% 1 Missing ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10496      +/-   ##
==========================================
+ Coverage   39.48%   39.51%   +0.03%     
==========================================
  Files         171      171              
  Lines       27324    27318       -6     
  Branches     1164     1167       +3     
==========================================
+ Hits        10789    10795       +6     
+ Misses      16535    16523      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balazsorban44 balazsorban44 merged commit ef0a31b into main Apr 6, 2024
13 of 15 checks passed
@balazsorban44 balazsorban44 deleted the ndom91/infer-provider-logo branch April 6, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` providers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants