Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ts): reduce public type surface #10557

Merged
merged 13 commits into from Apr 15, 2024
Merged

fix(ts): reduce public type surface #10557

merged 13 commits into from Apr 15, 2024

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Apr 12, 2024

We've been re-exporting some types in multiple places, which is confusing, and also exported some internal types.

Copy link

vercel bot commented Apr 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 15, 2024 9:16am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 9:16am

@github-actions github-actions bot added the core Refers to `@auth/core` label Apr 12, 2024
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 93.21429% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 40.58%. Comparing base (98266d0) to head (36042c7).
Report is 84 commits behind head on main.

Files Patch % Lines
packages/core/src/lib/utils/assert.ts 50.00% 11 Missing ⚠️
packages/core/src/types.ts 0.00% 4 Missing ⚠️
packages/core/src/providers/oauth.ts 0.00% 2 Missing ⚠️
packages/frameworks-solid-start/src/index.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10557      +/-   ##
==========================================
+ Coverage   38.53%   40.58%   +2.05%     
==========================================
  Files         171      172       +1     
  Lines       27080    27644     +564     
  Branches     1117     1174      +57     
==========================================
+ Hits        10435    11220     +785     
+ Misses      16645    16424     -221     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ndom91 ndom91 changed the title fix(ts): reudce public type surface fix(ts): reduce public type surface Apr 12, 2024
@balazsorban44 balazsorban44 marked this pull request as ready for review April 15, 2024 10:22
@balazsorban44 balazsorban44 merged commit 6ddc329 into main Apr 15, 2024
13 of 14 checks passed
@balazsorban44 balazsorban44 deleted the docs/reduce-ts-surface branch April 15, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants