fix(providers): update providers config from verification walk-throughs #10582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
balazsorban44
approved these changes
Apr 14, 2024
balazsorban44
requested changes
Apr 14, 2024
|
Can you also modify the |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10582 +/- ##
==========================================
+ Coverage 38.53% 39.76% +1.22%
==========================================
Files 171 172 +1
Lines 27080 27638 +558
Branches 1117 1165 +48
==========================================
+ Hits 10435 10989 +554
- Misses 16645 16649 +4 ☔ View full report in Codecov by Sentry. |
| ): OAuthConfig<P> { | ||
| const { issuer = "https://api.workos.com/" } = options | ||
| const { issuer = "https://api.workos.com/", connection = "" } = options |
Check failure
Code scanning / CodeQL
Hard-coded credentials Critical
balazsorban44
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
?scopeto theauthorizationUrlchecks: "nonce"connectionargument / env var which gets appended toauthorziationUrlas a search param@balazsorban44 two question:
checks: ("none" | "state" | "pkce"), are the types wrong or isnoncereally an invalid value?AUTH_WORKOS_CONNECTION. Usingprocess.envdirectly in the provider seems wrong since that won't work in all environments.. Do you have a better idea for this one? 🤔🧢 Checklist
🎫 Affected issues
📌 Resources