Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require secret at build-time #10592

Merged
merged 3 commits into from Apr 15, 2024
Merged

Conversation

balazsorban44
Copy link
Member

Follow-up on #10305

setEnvDefaults might be invoked during build which started throwing an error in #10305.

This reverts the early check and makes sure that the runtime check correctly catches an unavailable secret value, avoiding the cryptic message shown in #10305

Fixes #10538

Copy link

vercel bot commented Apr 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
auth-docs 🛑 Canceled (Inspect) Apr 15, 2024 11:13am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
next-auth-docs ⬜️ Ignored (Inspect) Visit Preview Apr 15, 2024 11:13am

@github-actions github-actions bot added the core Refers to `@auth/core` label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.48%. Comparing base (6ddc329) to head (bf38de4).
Report is 2 commits behind head on main.

❗ Current head bf38de4 differs from pull request most recent head d75f74c. Consider uploading reports for the commit d75f74c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10592   +/-   ##
=======================================
  Coverage   40.48%   40.48%           
=======================================
  Files         172      172           
  Lines       27754    27748    -6     
  Branches     1174     1168    -6     
=======================================
- Hits        11235    11233    -2     
+ Misses      16519    16515    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@balazsorban44 balazsorban44 marked this pull request as ready for review April 15, 2024 11:03
@balazsorban44 balazsorban44 merged commit b9cacec into main Apr 15, 2024
17 of 20 checks passed
@balazsorban44 balazsorban44 deleted the fix/build-time-secret branch April 15, 2024 11:25
4leite added a commit to Tohuhono/Oberon that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core` examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MissingSecret error during Next build since 5.0.0-beta.16
2 participants