Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(providers): Adding HubSpot Provider #4633

Merged
merged 16 commits into from Sep 11, 2022
Merged

feat(providers): Adding HubSpot Provider #4633

merged 16 commits into from Sep 11, 2022

Conversation

Miciurash
Copy link
Contributor

☕️ Reasoning

I've added the HubSpot Provider

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

@vercel
Copy link

vercel bot commented May 30, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-auth ✅ Ready (Inspect) Visit Preview Sep 10, 2022 at 3:43PM (UTC)

@github-actions github-actions bot added core Refers to `@auth/core` providers labels May 30, 2022
@vercel vercel bot temporarily deployed to Preview May 30, 2022 02:24 Inactive
@vercel vercel bot temporarily deployed to Preview June 6, 2022 13:05 Inactive
@Miciurash
Copy link
Contributor Author

@ndom91 @balazsorban44 - anything else I need to provide?

ThangHuuVu
ThangHuuVu requested changes Jun 9, 2022
View reviewed changes
Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I've added some comments

docs/docs/providers/hubspot.md Outdated Show resolved Hide resolved
packages/next-auth/src/providers/hubspot.ts Outdated Show resolved Hide resolved
packages/next-auth/src/providers/hubspot.ts Outdated Show resolved Hide resolved
packages/next-auth/src/providers/hubspot.ts Outdated Show resolved Hide resolved
packages/next-auth/src/providers/hubspot.ts Outdated Show resolved Hide resolved
@Miciurash @ThangHuuVu
Update docs/docs/providers/hubspot.md
622f7e9 
Co-authored-by: Thang Vu <31528554+ThangHuuVu@users.noreply.github.com>
@vercel vercel bot temporarily deployed to Preview June 18, 2022 13:17 Inactive
@vercel vercel bot temporarily deployed to Preview June 18, 2022 17:35 Inactive
ndom91
ndom91 reviewed Jul 10, 2022
View reviewed changes
SECURITY.md Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview August 11, 2022 03:23 Inactive
ThangHuuVu
ThangHuuVu reviewed Aug 13, 2022
View reviewed changes
Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for opening this PR! Let's finalize it soon together 🙌
Could you also attach a video for proof of completion? (This is for formality when integrating with a new provider. I tested your code already and it works fine for me)

@vercel vercel bot temporarily deployed to Preview August 20, 2022 23:55 Inactive
@Miciurash
Copy link
Contributor Author

@ThangHuuVu the video proof of the HubSpot login is available here: https://somup.com/c3jY0AUc97

@vercel vercel bot temporarily deployed to Preview August 20, 2022 23:58 Inactive
@Miciurash Miciurash requested review from ThangHuuVu and removed request for ubbe-xyz and balazsorban44 August 23, 2022 12:50
@vercel vercel bot temporarily deployed to Preview August 23, 2022 12:51 Inactive
@vercel vercel bot temporarily deployed to Preview August 29, 2022 05:10 Inactive
@Miciurash Miciurash requested review from ndom91 and ThangHuuVu and removed request for ThangHuuVu and ndom91 August 31, 2022 01:43
@Miciurash
Copy link
Contributor Author

@ndom91 @ThangHuuVu - are we good to merge here?

@vercel vercel bot temporarily deployed to Preview September 10, 2022 15:43 Inactive
ThangHuuVu
ThangHuuVu approved these changes Sep 11, 2022
View reviewed changes
Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ThangHuuVu ThangHuuVu changed the title Adding HubSpot Provider feat(providers): Adding HubSpot Provider Sep 11, 2022
@ThangHuuVu ThangHuuVu merged commit a0beb02 into nextauthjs:main Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndom91 ndom91 ndom91 left review comments

@ThangHuuVu ThangHuuVu ThangHuuVu approved these changes

Assignees
No one assigned
Labels
core Refers to `@auth/core` providers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Miciurash @ndom91 @ThangHuuVu