Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix builds/tests/eslint #4780

Merged
merged 23 commits into from Sep 9, 2022
Merged

chore: fix builds/tests/eslint #4780

merged 23 commits into from Sep 9, 2022

Conversation

balazsorban44
Copy link
Member

@balazsorban44 balazsorban44 commented Jun 28, 2022 •
edited

ESLint has not been working for me for a while now, I finally had a look at it to fix it. Builds also started failing locally, because of some missing types, which should be fixed now as well.

I also turned on linting on test files.

@vercel
Copy link

vercel bot commented Jun 28, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
next-auth ⬜️ Ignored (Inspect) Sep 8, 2022 at 4:08PM (UTC)

@github-actions github-actions bot added dgraph @auth/dgraph-adapter dynamodb @auth/dynamodb-adapter fauna @auth/fauna-adapter firebase @auth/firebase-adapter mikro-orm @auth/mikro-orm-adapter mongodb @auth/mongodb-adapter neo4j @auth/neo4j-adapter pouchdb @auth/pouchdb-adapter prisma @auth/prisma-adapter sequelize @auth/sequelize-adapter typeorm @auth/typeorm-adapter upstash-redis @auth/upstash-redis-adapter labels Jun 28, 2022
@balazsorban44 balazsorban44 changed the title chore(core): add/fix tests chore(core): fix builds/tests/eslint Jun 28, 2022
@balazsorban44 balazsorban44 changed the title chore(core): fix builds/tests/eslint chore: fix builds/tests/eslint Jun 28, 2022
@balazsorban44 balazsorban44 marked this pull request as draft June 28, 2022 12:44
@github-actions github-actions bot added adapters Changes related to the core code concerning database adapters typeorm-legacy labels Sep 3, 2022
ThangHuuVu
ThangHuuVu reviewed Sep 5, 2022
View reviewed changes
.eslintrc.js Outdated
@@ -0,0 +1,33 @@
const path = require('path')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved eslint config to here to use the path.resolve in parserOptions.project

balazsorban44
balazsorban44 commented Sep 7, 2022
View reviewed changes
.eslintignore Outdated Show resolved Hide resolved
balazsorban44
balazsorban44 commented Sep 7, 2022
View reviewed changes
.eslintrc.js Outdated
parser: "@typescript-eslint/parser",
parserOptions: {
project: [
path.resolve(__dirname, './packages/**/tsconfig.eslint.json'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be happy if this did not need to move out of package.json, but I see you are using path. I won't have strong feelings about it if there is no workaround. 🤔

Copy link
Member

@ThangHuuVu ThangHuuVu Sep 8, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved it inside pacakge.json again! I thought missing path and __dirname was the problem but it turned out weren't
Nope, we still need it here for parserOptions.project to work 😂

@ThangHuuVu ThangHuuVu marked this pull request as ready for review September 8, 2022 16:09
ndom91
ndom91 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@ndom91 ndom91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass.. LGTM 😊👍

@ThangHuuVu
Copy link
Member

@ndom91 great! @balazsorban44 and Nico, could you check if it works on your local machine? 🙌

@ndom91
Copy link
Member

ndom91 commented Sep 8, 2022

@ndom91 great! @balazsorban44 and Nico, could you check if it works on your local machine? 🙌

Yeah, can check later this evening when I'm back home 👍

@ThangHuuVu
Copy link
Member

ThangHuuVu commented Sep 9, 2022 •
edited

In your IDE, make sure to add Prettier configPath for auto-save. For example, in VSCode:

{
  "prettier.configPath": "package.json"
}

Merging this now, I pulled a fresh repo and it still works 🤞

@balazsorban44 balazsorban44 merged commit 8104cb1 into main Sep 9, 2022
@balazsorban44 balazsorban44 deleted the chore/add-tests branch September 9, 2022 11:51
@vedantmgoyal9 vedantmgoyal9 mentioned this pull request Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndom91 ndom91 ndom91 approved these changes

@ThangHuuVu ThangHuuVu ThangHuuVu approved these changes

@ubbe-xyz ubbe-xyz Awaiting requested review from ubbe-xyz ubbe-xyz is a code owner

Assignees
No one assigned
Labels
adapters Changes related to the core code concerning database adapters dgraph @auth/dgraph-adapter dynamodb @auth/dynamodb-adapter fauna @auth/fauna-adapter firebase @auth/firebase-adapter mikro-orm @auth/mikro-orm-adapter mongodb @auth/mongodb-adapter neo4j @auth/neo4j-adapter pouchdb @auth/pouchdb-adapter prisma @auth/prisma-adapter sequelize @auth/sequelize-adapter typeorm @auth/typeorm-adapter typeorm-legacy upstash-redis @auth/upstash-redis-adapter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balazsorban44 @ThangHuuVu @ndom91 @thang-vu-20230331