chore: turbo cleanup

[balazsorban44]

Turbo should take care of dependencies in dev now.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Updated
next-auth	⬜️ Ignored (Inspect)		Sep 8, 2022 at 7:05AM (UTC)

[balazsorban44]

I'm not sure why this is necessary though:

next-auth/turbo.json

Lines 11 to 26 in 1872855

	"@next-auth/fauna-adapter#build": {
	"dependsOn": ["next-auth#build"]
	},
	"@next-auth/prisma-adapter#build": {
	"dependsOn": ["next-auth#build"]
	},
	"@next-auth/typeorm-legacy-adapter#build": {
	"dependsOn": ["next-auth#build"]
	},
	"dev": {
	"cache": false,
	"dependsOn": [
	"@next-auth/fauna-adapter#build",
	"@next-auth/prisma-adapter#build",
	"@next-auth/typeorm-legacy-adapter#build"
	]

I thought this should be enough:

"dev": {
  "cache": false,
  "dependsOn": ["^build"]
},

But I have to explicitly add the build of the adapters, and define that each adapter dependsOn next-auth#build (because of the types)

[balazsorban44]

Not sure why the test fails... It works locally, but not on GitHub, even after 4ff836a. 🤔

[ThangHuuVu]

I've got some suggestions 🚀

[balazsorban44]

@ThangHuuVu what's remaining here is to clean up apps/dev:

next-auth/apps/dev/package.json

Lines 7 to 11 in ba20974

	"clean": "rm -rf .next",
	"copy:css": "cpx \"../../packages/next-auth/css/**/*\" src/css --watch",
	"watch:css": "cd ../../packages/next-auth && pnpm watch:css",
	"dev": "concurrently \"pnpm dev:next\" \"pnpm watch:css\" \"pnpm copy:css\"",
	"dev:next": "next dev",

I think this should be simplified. pnpm dev should watch next-auth (both js and CSS) and Turbo should make sure that the dev app gets the updates from there with HMR, no copying or

next-auth/apps/dev/next.config.js

Line 8 in ba20974

experimental: { externalDir: true },

should be necessary.

[ThangHuuVu]

@ThangHuuVu what's remaining here is to clean up apps/dev:

next-auth/apps/dev/package.json

Lines 7 to 11 in ba20974

	"clean": "rm -rf .next",
	"copy:css": "cpx \"../../packages/next-auth/css/**/*\" src/css --watch",
	"watch:css": "cd ../../packages/next-auth && pnpm watch:css",
	"dev": "concurrently \"pnpm dev:next\" \"pnpm watch:css\" \"pnpm copy:css\"",
	"dev:next": "next dev",

I think this should be simplified. pnpm dev should watch next-auth (both js and CSS) and Turbo should make sure that the dev app gets the updates from there with HMR, no copying or

next-auth/apps/dev/next.config.js

Line 8 in ba20974

experimental: { externalDir: true },

should be necessary.

@balazsorban44 I added next-auth as apps/dev dependency now.
It introduces some new changes in the setup:

• build is no longer required for dev
• Remove copy:css
• Bring back --parallel and add --continue for dev