fix: return null in unstable_getServerSession if there's an error #5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
ThangHuuVu
requested changes
Aug 30, 2022
melanieseltzer
force-pushed
the
fix-bug-unstable_getServerSession
branch
from
601090f
to
1b5e6a6
Compare
|
Thanks for the review @ThangHuuVu, have addressed your comments 😄 |
ThangHuuVu
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Make sure
unstable_getServerSessionreturns null if there's a config error underneath. Previously in that scenario, it was returning a string of the error page HTML (see linked issue for details).🧢 Checklist
🎫 Affected issues
Fixes: #5166
📌 Resources