fix(providers): Include client_id and client_secret in LinkedIn token request
#5236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Linkedin now requires client_id and client_secret to be sent in the oauth callback. Fixes nextauthjs#5220
sildur
force-pushed
the
required_fields_for_linkedin
branch
from
33f66ed
to
b6d332e
Compare
ThangHuuVu
approved these changes
Aug 30, 2022
ThangHuuVu
changed the title
client_id and client_secret in LinkedIn token request
Comment on lines
33
to
51
| token: { | ||
| url: "https://www.linkedin.com/oauth/v2/accessToken", | ||
| async request({ | ||
| client, | ||
| params, | ||
| checks, | ||
| provider | ||
| }) { | ||
| const response = await client.oauthCallback(provider.callbackUrl, params, checks, { | ||
| exchangeBody: { | ||
| client_id: options.clientId, | ||
| client_secret: options.clientSecret, | ||
| } | ||
| }); | ||
| return { | ||
| tokens: response | ||
| }; | ||
| } | ||
| }, |
There was a problem hiding this comment.
This is not necessary, you can just add the following config:
client: {
token_endpoint_auth_method: "client_secret_post",
},Read more here: https://next-auth.js.org/configuration/providers/oauth#client-option
I verified this locally:
There was a problem hiding this comment.
the solution from @balazsorban44 works for me as well, thanks
balazsorban44
requested changes
Aug 30, 2022
There was a problem hiding this comment.
Thanks for the PR! Could you please address my review so we can merge this? 🙏
I had the same comment on your other PR here: #5225 (review)
7 tasks
3 tasks
balazsorban44
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linkedin now requires client_id and client_secret to be
sent in the oauth callback. Fixes #5220
Edit: related: https://docs.microsoft.com/en-us/linkedin/shared/authentication/authorization-code-flow?context=linkedin%2Fcontext&view=li-lms-2022-08&tabs=HTTPS#step-3-exchange-authorization-code-for-an-access-token
☕️ Reasoning
Linkedin now requires client_id and client_secret to be
sent in the oauth callback. This PR adds them. Fixes #5220
🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes: #5220
📌 Resources