Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change getToken parameter type to required #5245

Conversation

JohnMarsden24
Copy link
Contributor

☕️ Reasoning

This PR changes the parameter TypeScript type for getToken to required as previously it was optional.

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: getToken requires request to be passed but has params as optional

📌 Resources

@vercel
Copy link

vercel bot commented Aug 29, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
next-auth ❌ Failed (Inspect) Sep 2, 2022 at 5:25AM (UTC)

@github-actions github-actions bot added the core Refers to `@auth/core` label Aug 29, 2022
Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JohnMarsden24, thanks for the PR
Could you also remove this part ?? {} at line 82? It won't be necessary anymore 🙌

@JohnMarsden24
Copy link
Contributor Author

Hey @JohnMarsden24, thanks for the PR Could you also remove this part ?? {} at line 82? It won't be necessary anymore 🙌

Done in latest commit!

@ThangHuuVu ThangHuuVu merged commit d3571e0 into nextauthjs:main Sep 2, 2022
@JohnMarsden24 JohnMarsden24 deleted the fix/change-getToken-parameter-type-to-required branch September 2, 2022 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Refers to `@auth/core`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getToken requires request to be passed but has params as optional
3 participants