Add option for custom generateSessionToken #5328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
halfmatthalfcat
requested review from
ubbe-xyz,
ThangHuuVu and
ndom91
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
added
core
halfmatthalfcat
force-pushed
the
custom-generateSessionToken
branch
from
7b13aa5
to
d7e2e81
Compare
|
@lluia @ThangHuuVu @ndom91 thoughts? |
ThangHuuVu
requested changes
Sep 17, 2022
halfmatthalfcat
force-pushed
the
custom-generateSessionToken
branch
from
01cad38
to
40b5b93
Compare
halfmatthalfcat
requested review from
ThangHuuVu
and removed request for
ubbe-xyz and
ndom91
halfmatthalfcat
force-pushed
the
custom-generateSessionToken
branch
from
5ffedf8
to
577f688
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
Instead of a random UUID, I want to leverage
cuidas the session token. This PR allows the ability to define a customgenerateSessionTokenfunction and return the custom session token. Leverage original logic (random UUID) by default.🧢 Checklist
🎫 Affected issues
Please scout and link issues that might be solved by this PR.
Fixes: N/A
📌 Resources