Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add Next to peerDeps & bump to 12.2.5 in devDeps #5384

Merged
merged 3 commits into from Sep 24, 2022
Merged

chore: Add Next to peerDeps & bump to 12.2.5 in devDeps #5384

merged 3 commits into from Sep 24, 2022

Conversation

ThomasLarge
Copy link
Contributor

☕️ Reasoning

187945312-2b8bde8b-ce71-42c3-bdad-0e3cc40e625f

On the left are the new types from NextJS and on the Right are the types that getToken is using. When upgrading NextJS passed 12.2.0 the types become incompatible.

187945725-563f1b78-6273-45de-886e-c01cea039f4a

This is the type of error when upgrading to NextJS v12.2.5

🎫 Affected issues

Main GitHub Issue

@vercel
Copy link

vercel bot commented Sep 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
next-auth ⬜️ Ignored (Inspect) Sep 23, 2022 at 5:31PM (UTC)

@ThangHuuVu ThangHuuVu changed the title feat: GH-5274: Upgrade nextJs to 12.2.5 chore: Add Next to peerDeps & bump to 12.2.5 in devDeps Sep 23, 2022
@ThangHuuVu
Copy link
Member

Thanks, could you update the lock file as well? It is required for CI

@ThomasLarge
Copy link
Contributor Author

Thanks, could you update the lock file as well? It is required for CI

Sure yeah, sorry I missed that!

Copy link
Member

@ThangHuuVu ThangHuuVu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks again 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants