feat: tweak sign-in page design #6774
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
balazsorban44
had a problem deploying
to
Preview
GitHub Actions
Failure
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| return ( | ||
| <div key={provider.id} className="provider"> | ||
| {provider.type === "oauth" || provider.type === "oidc" ? ( | ||
| <form action={provider.signinUrl} method="POST"> |
Check warning
Code scanning / CodeQL
Exception text reinterpreted as HTML Medium
| height={24} | ||
| width={24} | ||
| id="provider-logo" | ||
| src={logo} |
Check warning
Code scanning / CodeQL
Exception text reinterpreted as HTML Medium
| height={24} | ||
| width={24} | ||
| id="provider-logo-dark" | ||
| src={logoDark} |
Check warning
Code scanning / CodeQL
Exception text reinterpreted as HTML Medium
| providers[i - 1].type !== "email" && | ||
| providers[i - 1].type !== "credentials" && <hr />} | ||
| {provider.type === "email" && ( | ||
| <form action={provider.signinUrl} method="POST"> |
Check warning
Code scanning / CodeQL
Exception text reinterpreted as HTML Medium
| </form> | ||
| )} | ||
| {provider.type === "credentials" && ( | ||
| <form action={provider.callbackUrl} method="POST"> |
Check warning
Code scanning / CodeQL
Exception text reinterpreted as HTML Medium
balazsorban44
force-pushed
the
main
branch
2 times, most recently
from
9784f29
to
37bb6eb
Compare
ThangHuuVu
force-pushed
the
feat/simplify-logos
branch
from
6ca5220
to
a1ed3cc
Compare
ThangHuuVu
had a problem deploying
to
Preview
GitHub Actions
Failure
| src={`${ | ||
| provider.style.logo.startsWith("/") ? logos : "" | ||
| }${provider.style.logoDark}`} | ||
| {theme.logo && <img src={theme.logo} alt="Logo" className="logo" />} |
Check warning
Code scanning / CodeQL
Exception text reinterpreted as HTML Medium
balazsorban44
requested review from
ThangHuuVu,
ubbe-xyz and
ndom91
as code owners
Instead of requiring two distinct logos and colors (light/dark) for each provider, we could default to use the light version for both themes and make the dark options optional. Most of the provider buttons look good on both color schemes already.
Before merging, I would like to implement some proper hover/focus state for our buttons for better a11y