Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent beta fails to install #573

Closed
juliushaertl opened this issue Jun 28, 2023 · 4 comments
Closed

Recent beta fails to install #573

juliushaertl opened this issue Jun 28, 2023 · 4 comments

Comments

@juliushaertl
Copy link
Contributor

I think it needs a bump of eslint-config-standard for standard/eslint-config-standard@1458f04

~/repos/nextcloud/server/apps/text renovate/main-nextcloud-eslint-config-8.x✦ ➜ npm ci && npm run test
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: eslint-config-standard@17.0.0
npm ERR! Found: eslint-plugin-n@16.0.1
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^16.0.0" from @nextcloud/eslint-config@8.3.0-beta.2
npm ERR!   node_modules/@nextcloud/eslint-config
npm ERR!     dev @nextcloud/eslint-config@"^8.3.0-beta.2" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-n@"^15.0.0" from eslint-config-standard@17.0.0
npm ERR! node_modules/eslint-config-standard
npm ERR!   peer eslint-config-standard@"^17.0.0" from @nextcloud/eslint-config@8.3.0-beta.2
npm ERR!   node_modules/@nextcloud/eslint-config
npm ERR!     dev @nextcloud/eslint-config@"^8.3.0-beta.2" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: eslint-plugin-n@15.7.0
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^15.0.0" from eslint-config-standard@17.0.0
npm ERR!   node_modules/eslint-config-standard
npm ERR!     peer eslint-config-standard@"^17.0.0" from @nextcloud/eslint-config@8.3.0-beta.2
npm ERR!     node_modules/@nextcloud/eslint-config
npm ERR!       dev @nextcloud/eslint-config@"^8.3.0-beta.2" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/julius/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/julius/.npm/_logs/2023-06-28T06_40_46_075Z-debug-0.log
@skjnldsv
Copy link
Contributor

I had the issue, but we're alreayd using latest: #569

@skjnldsv
Copy link
Contributor

skjnldsv commented Jun 28, 2023

can you:

  1. remove lockfile
  2. remove node_modules
  3. install @nextcloud/eslint-config@8.3.0-beta.2

See if that works

EDIT: just did it, and it worked, see nextcloud/text#4402
Also it updated your lockfile version, explaining the many changed lines

@juliushaertl
Copy link
Contributor Author

Yes i didn't remove the lock file but just manually committed the relevant version bumps in it. Strange that npm cannot handle this as the peerDependency range of @nextcloud/eslint-config should be fine.

@skjnldsv
Copy link
Contributor

I think it's because we use npm ci, and renovate will not update the lockfile version, so it's our responsibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants