Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nextcloud-libraries/nextcloud-dialogs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.3.3
Choose a base ref
...
head repository: nextcloud-libraries/nextcloud-dialogs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.3.4
Choose a head ref
  • 14 commits
  • 4 files changed
  • 3 contributors

Commits on Jun 22, 2024

  1. chore(deps-dev): Bump sass from 1.77.5 to 1.77.6

    Bumps [sass](https://github.com/sass/dart-sass) from 1.77.5 to 1.77.6.
    - [Release notes](https://github.com/sass/dart-sass/releases)
    - [Changelog](https://github.com/sass/dart-sass/blob/main/CHANGELOG.md)
    - [Commits](sass/dart-sass@1.77.5...1.77.6)
    
    ---
    updated-dependencies:
    - dependency-name: sass
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Jun 22, 2024

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    susnux Ferdinand Thiessen
    Copy the full SHA
    6c24782 View commit details
  2. chore(deps-dev): Bump @nextcloud/vite-config from 1.2.3 to 1.3.0

    Bumps [@nextcloud/vite-config](https://github.com/nextcloud/nextcloud-vite-config) from 1.2.3 to 1.3.0.
    - [Release notes](https://github.com/nextcloud/nextcloud-vite-config/releases)
    - [Changelog](https://github.com/nextcloud-libraries/nextcloud-vite-config/blob/v1.3.0/CHANGELOG.md)
    - [Commits](nextcloud-libraries/nextcloud-vite-config@v1.2.3...v1.3.0)
    
    ---
    updated-dependencies:
    - dependency-name: "@nextcloud/vite-config"
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Jun 22, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    1d6f576 View commit details
  3. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    a46aabf View commit details
  4. chore(deps-dev): Bump happy-dom from 14.12.0 to 14.12.3

    Bumps [happy-dom](https://github.com/capricorn86/happy-dom) from 14.12.0 to 14.12.3.
    - [Release notes](https://github.com/capricorn86/happy-dom/releases)
    - [Commits](capricorn86/happy-dom@v14.12.0...v14.12.3)
    
    ---
    updated-dependencies:
    - dependency-name: happy-dom
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Jun 22, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    6f1ace9 View commit details
  5. Merge pull request #1366 from nextcloud-libraries/dependabot/npm_and_…

    …yarn/nextcloud/vite-config-1.3.0
    dependabot[bot] authored Jun 22, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    59c74bd View commit details
  6. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    4be6806 View commit details

Commits on Jun 24, 2024

  1. fix(FilePicker): Forward update of currentPath to navigatedPath

    Allow to use `:path.sync="currentPath"` and fixes regression where changing the folder
    by clicking a folder in the file list does not navigate to that folder.
    
    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed Jun 24, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    c9a5872 View commit details
  2. chore(deps-dev): Bump typedoc from 0.25.13 to 0.26.0

    Bumps [typedoc](https://github.com/TypeStrong/TypeDoc) from 0.25.13 to 0.26.0.
    - [Release notes](https://github.com/TypeStrong/TypeDoc/releases)
    - [Changelog](https://github.com/TypeStrong/typedoc/blob/master/CHANGELOG.md)
    - [Commits](TypeStrong/typedoc@v0.25.13...v0.26.0)
    
    ---
    updated-dependencies:
    - dependency-name: typedoc
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and susnux committed Jun 24, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    a264a6f View commit details
  3. Merge pull request #1367 from nextcloud-libraries/dependabot/npm_and_…

    …yarn/typedoc-0.26.0
    
    chore(deps-dev): Bump typedoc from 0.25.13 to 0.26.0
    susnux authored Jun 24, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    1d4f5c4 View commit details
  4. chore(deps-dev): Bump typescript from 5.4.5 to 5.5.2

    Bumps [typescript](https://github.com/Microsoft/TypeScript) from 5.4.5 to 5.5.2.
    - [Release notes](https://github.com/Microsoft/TypeScript/releases)
    - [Changelog](https://github.com/microsoft/TypeScript/blob/main/azure-pipelines.release.yml)
    - [Commits](microsoft/TypeScript@v5.4.5...v5.5.2)
    
    ---
    updated-dependencies:
    - dependency-name: typescript
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Jun 24, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    ccb2237 View commit details
  5. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    d7560bb View commit details
  6. Merge pull request #1370 from nextcloud-libraries/fix/update-path

    fix(FilePicker): Forward update of `currentPath` to `navigatedPath`
    Pytal authored Jun 24, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    05b78d8 View commit details

Commits on Jun 25, 2024

  1. chore: Prepare v5.3.4

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed Jun 25, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f6aa7be View commit details
  2. Merge pull request #1372 from nextcloud-libraries/chore/prepare-5-3-4

    chore: Prepare v5.3.4
    susnux authored Jun 25, 2024

    Verified

    This commit was signed with the committer’s verified signature.
    AndyScherzinger Andy Scherzinger
    Copy the full SHA
    f56481a View commit details
Showing with 240 additions and 299 deletions.
  1. +13 −0 CHANGELOG.md
  2. +12 −7 lib/components/FilePicker/FilePicker.vue
  3. +208 −285 package-lock.json
  4. +7 −7 package.json
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -6,6 +6,19 @@

All notable changes to this project will be documented in this file.

## 5.3.4
[Full Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/compare/v5.3.3...v5.3.4)

### Fixed
* fix(FilePicker): Forward update of `currentPath` to `navigatedPath` [\#1370](https://github.com/nextcloud-libraries/nextcloud-dialogs/pull/1370) \([susnux](https://github.com/susnux)\)

### Changed
* chore(deps-dev): Bump sass to 1.77.6
* chore(deps-dev): Bump @nextcloud/vite-config to 1.3.0
* chore(deps-dev): Bump happy-dom to 14.12.3
* chore(deps-dev): Bump typedoc to 0.26.0
* chore(deps-dev): Bump typescript to 5.5.2

## [v5.3.3](https://github.com/nextcloud-libraries/nextcloud-dialogs/tree/v5.3.3) (2024-06-21)
[Full Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/compare/v5.3.2...v5.3.3)

19 changes: 12 additions & 7 deletions lib/components/FilePicker/FilePicker.vue
Original file line number Diff line number Diff line change
@@ -22,10 +22,9 @@
<div class="file-picker__main">
<!-- Header title / file list breadcrumbs -->
<FilePickerBreadcrumbs v-if="currentView === 'files'"
:path="currentPath"
:path.sync="currentPath"
:show-menu="allowPickDirectory"
@create-node="onCreateFolder"
@update:path="navigatedPath = $event" />
@create-node="onCreateFolder" />
<div v-else class="file-picker__view">
<h3>{{ viewHeadline }}</h3>
</div>
@@ -212,10 +211,16 @@ watch([navigatedPath], () => {
/**
* The current path that should be picked from
*/
const currentPath = computed(() =>
// Only use the path for the files view as favorites and recent only works on the root
currentView.value === 'files' ? navigatedPath.value || props.path || savedPath.value : '/',
)
const currentPath = computed({
get: () => {
// Only use the path for the files view as favorites and recent only works on the root
return currentView.value === 'files' ? navigatedPath.value || props.path || savedPath.value : '/'
},
set: (path: string) => {
// forward setting the current path to the navigated path
navigatedPath.value = path
},
})

/**
* A string used to filter files in current view
Loading