Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nextcloud-libraries/nextcloud-dialogs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v5.3.6
Choose a base ref
...
head repository: nextcloud-libraries/nextcloud-dialogs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v5.3.7
Choose a head ref
  • 4 commits
  • 4 files changed
  • 2 contributors

Commits on Aug 21, 2024

  1. fix: Fetch also current folder in DAV

    Regression from the revert. We need to fetch the current folder so we can pick it.
    
    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed Aug 21, 2024

    Verified

    This commit was signed with the committer’s verified signature. The key has expired.
    susnux Ferdinand Thiessen
    Copy the full SHA
    7d71ea3 View commit details
  2. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    6c5c29b View commit details
  3. chore: Prepare v5.3.7

    Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
    susnux committed Aug 21, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    f4f8d4b View commit details
  4. Merge pull request #1429 from nextcloud-libraries/chore/v5.3.7

    chore: Prepare v5.3.7
    susnux authored Aug 21, 2024

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature.
    Copy the full SHA
    4764cd5 View commit details
Showing with 16 additions and 10 deletions.
  1. +6 −0 CHANGELOG.md
  2. +7 −7 lib/composables/dav.ts
  3. +2 −2 package-lock.json
  4. +1 −1 package.json
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -6,6 +6,12 @@

All notable changes to this project will be documented in this file.

## 5.3.7
[Full Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/compare/v5.3.6...v5.3.7)

### Fixed
* fix: Fetch also current folder in DAV [\#1428](https://github.com/nextcloud-libraries/nextcloud-dialogs/pull/1428) \([susnux](https://github.com/susnux)\)

## 5.3.6
[Full Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/compare/v5.3.5...v5.3.6)

14 changes: 7 additions & 7 deletions lib/composables/dav.ts
Original file line number Diff line number Diff line change
@@ -73,22 +73,22 @@ export const useDAVFiles = function(
})
}

const getNodes = (): CancelablePromise<Node[]> => {
const getNodes = (): CancelablePromise<ContentsWithRoot> => {
const controller = new AbortController()
return new CancelablePromise(async (resolve, reject, onCancel) => {
onCancel(() => controller.abort())
try {
const results = await client.value.getDirectoryContents(`${defaultRootPath}${currentPath.value}`, {
signal: controller.signal,
details: true,
includeSelf: true,
data: davGetDefaultPropfind(),
}) as ResponseDataDetailed<FileStat[]>
let nodes = results.data.map(resultToNode)
// Hack for the public endpoint which always returns folder itself
if (isPublicEndpoint) {
nodes = nodes.filter((file) => file.path !== currentPath.value)
}
resolve(nodes)
const nodes = results.data.map(resultToNode)
resolve({
folder: nodes.find((file) => file.path === currentPath.value) as Folder,
contents: nodes.filter((file) => file.path !== currentPath.value),
})
} catch (error) {
reject(error)
}
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nextcloud/dialogs",
"version": "5.3.6",
"version": "5.3.7",
"description": "Nextcloud dialog helpers",
"types": "dist/index.d.ts",
"main": "dist/index.cjs",