Modal close button missing after 5.x

[juliushaertl]

This seems to occur in viewer as well as on the documentation examples:

https://nextcloud-vue-components.netlify.app/#/Components/Modal

For some reason the single entry item for rendering the ActionButton seems to be missing:

l

[juliushaertl]

[juliushaertl]

@skjnldsv Any idea why that could happen? Found this when guiding @vinicius73 a bit through our frontend development stack.

Seems to come from https://github.com/nextcloud/nextcloud-vue/blob/master/src/components/Actions/Actions.vue#L463 but I cannot really explain why this only happens in the modal, while the same combination of a single ActionButton works fine outside.

Further this was introduced somewhere between 4.4.0 and 5.0.0.

[vinicius73]

It is related to the last release of Vue
vuejs/vue#12104
vuejs/vue#12102

Probably the slots are not yet available in the created life cycle, because of that the reactivity of Actions.vue does not detect the icon slot.

[skjnldsv]

It is related to the last release of Vue
vuejs/vue#12104

seems to be fixed with 2.6.14 which we are using 🤔

[juliushaertl]

Bisecting showed #2385 as the commit causing the regression. Might be that the upstream change from functional to regular components now causes the rendering to happen earlier when the slot details are not fully available