Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NcSelect instead of NcMultiselect in the components #3743

Closed
5 tasks done
raimund-schluessler opened this issue Feb 12, 2023 · 6 comments
Closed
5 tasks done

Use NcSelect instead of NcMultiselect in the components #3743

raimund-schluessler opened this issue Feb 12, 2023 · 6 comments
Labels
1. to develop Accepted and waiting to be taken care of feature: select Related to the NcSelect* components technical debt
Milestone

Comments

@raimund-schluessler raimund-schluessler added 1. to develop Accepted and waiting to be taken care of feature: select Related to the NcSelect* components technical debt labels Feb 12, 2023
@Pytal
Copy link
Contributor

Pytal commented Feb 13, 2023

master currently targets v7 major, so this breaking change will have to be done for v8

@Pytal Pytal modified the milestones: 7.6.0, 8.0.0 Feb 13, 2023
@raimund-schluessler
Copy link
Contributor Author

master currently targets v7 major, so this breaking change will have to be done for v8

I think it doesn't have to be a breaking change if we do it right.

@Pytal
Copy link
Contributor

Pytal commented Feb 14, 2023

I think it doesn't have to be a breaking change if we do it right.

Could review a non-breaking PR if you'd be so inclined then :)

@raimund-schluessler raimund-schluessler modified the milestones: 8.0.0, 7.8.0 Feb 28, 2023
@julien-nc julien-nc modified the milestones: 7.8.0, 7.9.0 Mar 2, 2023
@raimund-schluessler raimund-schluessler mentioned this issue Mar 4, 2023
2 tasks
@raimund-schluessler raimund-schluessler modified the milestones: 7.9.0, 7.8.1 Mar 11, 2023
@julien-nc julien-nc modified the milestones: 7.8.1, 7.8.2 Mar 16, 2023
@mejo- mejo- modified the milestones: 7.8.2, 7.8.3 Mar 22, 2023
@nickvergessen nickvergessen modified the milestones: 7.8.3, 7.8.4, 7.8.5, 7.8.6 Mar 23, 2023
@julien-nc julien-nc removed this from the 7.8.6 milestone Apr 7, 2023
@raimund-schluessler
Copy link
Contributor Author

@mejo- or @julien-nc Would one of you have time to move NcSearch and NcProviderList to use NcSelect as well? I think that would be nice, as NcSelect is also more accessbile.

@julien-nc
Copy link
Contributor

@raimund-schluessler Yes sure, done in #4247

@raimund-schluessler
Copy link
Contributor Author

Closed with #4247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: select Related to the NcSelect* components technical debt
Projects
None yet
Development

No branches or pull requests

6 participants