Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename title props to name #4053

Closed
raimund-schluessler opened this issue May 7, 2023 · 3 comments · Fixed by #4106
Closed

Rename title props to name #4053

raimund-schluessler opened this issue May 7, 2023 · 3 comments · Fixed by #4106
Assignees
@nickvergessen @susnux @skjnldsv @Pytal @ShGKme @marcoambrosini
Labels
1. to develop Accepted and waiting to be taken care of accessibility Making sure we design for the widest range of people possible, including those who have disabilities breaking PR that requires a new major version question Further information is requested
Milestone
8.0.0

Comments

@raimund-schluessler
Copy link
Contributor

Since we now use the title prop as the native html attribute, and for some components are about to deprecate its usage for specifying the name of an element with it in #4052, I wonder whether we should generally rename title props to name if they are not specifically meant for setting the native html attribute.

The benefit would be that its consistent between components and would prevent future migrations for when we want to set the native html title attribute for a component. The drawback is that it would introduce a relatively big migration effort for apps.

So I would like to know your opinion about that, before I possibly start to rename this prop.
@raimund-schluessler raimund-schluessler added the question Further information is requested label May 7, 2023
@raimund-schluessler raimund-schluessler added this to the 8.0.0 milestone May 7, 2023
@nickvergessen
Copy link
Contributor

Sounds good I guess

@nickvergessen nickvergessen added the accessibility Making sure we design for the widest range of people possible, including those who have disabilities label May 8, 2023
@susnux
Copy link
Contributor

susnux commented May 8, 2023

I wonder whether we should generally rename title props to name if they are not specifically meant for setting the native html attribute.

I agree. I think using title only for the native html title attribute as it is generally quite confusing if you reuse a property name which is already in use as a native html attribute.

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label May 9, 2023
@skjnldsv
Copy link
Contributor

skjnldsv commented May 9, 2023

Also agree 👍

@raimund-schluessler raimund-schluessler added the breaking PR that requires a new major version label May 11, 2023
@raimund-schluessler raimund-schluessler linked a pull request May 12, 2023 that will close this issue
Rename title props and slots to name #4106
Merged
@raimund-schluessler raimund-schluessler mentioned this issue May 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickvergessen nickvergessen

@susnux susnux

@skjnldsv skjnldsv

@Pytal Pytal

@ShGKme ShGKme

@marcoambrosini marcoambrosini

Labels
1. to develop Accepted and waiting to be taken care of accessibility Making sure we design for the widest range of people possible, including those who have disabilities breaking PR that requires a new major version question Further information is requested
Projects
None yet
Milestone
8.0.0
Development

Successfully merging a pull request may close this issue.

Rename title props and slots to name nextcloud-libraries/nextcloud-vue
7 participants
@nickvergessen @susnux @raimund-schluessler @skjnldsv @Pytal @ShGKme @marcoambrosini