Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcModal close button is inaccessible with scrollable content #4627

Closed
Antreesy opened this issue Oct 9, 2023 · 1 comment · Fixed by #4645
Closed

NcModal close button is inaccessible with scrollable content #4627

Antreesy opened this issue Oct 9, 2023 · 1 comment · Fixed by #4645
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: modal Related to the modal component
Milestone

Comments

@Antreesy
Copy link
Contributor

Antreesy commented Oct 9, 2023

Issue:

Screenshots:
image
image

Possible solution:

  • set z-index: 1 for modal-container__close

Originally posted by @Antreesy in #4350 (comment)

@Antreesy Antreesy added bug Something isn't working 1. to develop Accepted and waiting to be taken care of feature: modal Related to the modal component labels Oct 9, 2023
@Antreesy Antreesy added this to the 8.0.0 milestone Oct 9, 2023
@susnux
Copy link
Contributor

susnux commented Oct 13, 2023

BTW this is caused by talk resetting the modal content margin, normally there is a margin of 50px so there should be not content overlapping the button.

@susnux susnux self-assigned this Oct 15, 2023
@susnux susnux added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working feature: modal Related to the modal component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants