Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NcRichContenteditable: @mention item is not rendered properly in other apps #4901

Closed
Antreesy opened this issue Dec 1, 2023 · 0 comments · Fixed by nextcloud-libraries/nextcloud-vite-config#112
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components regression Regression of a previous working feature
Milestone

Comments

@Antreesy
Copy link
Contributor

Antreesy commented Dec 1, 2023

Am I right that now styles are not loaded from .js but loaded by require('path-to.css') inside modules?

Might be related to it?

  • with import of NcRichContenteditable to the project also the component NcMentionBubble is bundled with id '357e6d0e' (which will be used for styles scope in [data-v-357e6d0e])
  • NcRichContenteditable is using mixin richEditor under the hood, which is in charge of rendering NcMentionBubble. It is also bundled in the project with id '8a961b36'
  • dist/assets/NcMentionBubble-<hash>.css contains styles for scope data-v-357e6d0e, same as source webpack://./node_modules/@nextcloud/vue/dist/assets/index.css in production code
  • dev environment seems to use mjs, where styles applied only for [data-v-8a961b36]

That causes the styles for rendered mentions to be broken, if lib is used in Talk, for example:
image

Content in a bundled app:

  1. NcMentionBundle with id '357e6d0e'
  2. Styles for id '8a961b36'
  3. NcMentionBundle with id '8a961b36'
    Screenshot from 2023-10-12 10-26-42

Originally posted by @Antreesy in #4386 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components regression Regression of a previous working feature
Projects
None yet
5 participants