Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NcRichContenteditable] Pressing ESC not only closes the link picker but also unfocuses the input #5352

Closed
ShGKme opened this issue Mar 6, 2024 · 4 comments · Fixed by #5353
Assignees
Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components

Comments

@ShGKme
Copy link
Contributor

ShGKme commented Mar 6, 2024

A part of #5351

@ShGKme ShGKme added bug Something isn't working 2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities feature: rich-contenteditable Related to the rich-contenteditable components labels Mar 6, 2024
@ShGKme ShGKme self-assigned this Mar 6, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 6, 2024

Not reproducible in @nextcloud/vue, only in Talk.

@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 6, 2024

Happens after #4907

Talk handled tribute active status via its tribute-active-true/tribute-active-false events. But these events don't bubble and don't work when tribute target is not the root element of the component.

@Antreesy
Copy link
Contributor

Antreesy commented Mar 6, 2024

https://v3-migration.vuejs.org/breaking-changes/v-on-native-modifier-removed.html#migration-strategy

.native should be removed anyway (which we using for Talk), so I'd say, easiest way would be to emit event from the component

@ShGKme
Copy link
Contributor Author

ShGKme commented Mar 6, 2024

.native should be removed anyway (which we using for Talk), so I'd say, easiest way would be to emit event from the component

It is not actually breaking, it will just work the same in Vue 3 after removing .native. This is a problem for migration only when there is a component event with exactly the same name as a native event.

Talk needed tribute-active-* events to handle @keydown.esc only for input itself, not when Escape closes Tribute autocomplite. A better solution from the NcRichContenteditable side would be to not bubble keydown for escape that closes autocomplete.

Emitting tribute-active-* events as it is also means that Tribute is now a part of the component interface and cannot be replaced with an alternative solution.

@ShGKme ShGKme assigned Antreesy and unassigned ShGKme Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress accessibility Making sure we design for the widest range of people possible, including those who have disabilities bug Something isn't working feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
2 participants