Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting error in PropertyDateTime.vue #1484

Closed
nickvergessen opened this issue Feb 25, 2020 · 6 comments · Fixed by #1497
Closed

Linting error in PropertyDateTime.vue #1484

nickvergessen opened this issue Feb 25, 2020 · 6 comments · Fixed by #1497
Labels
bug Something isn't working

Comments

@nickvergessen
Copy link
Member 

Cannot read property 'indexOf' of undefined
Occurred while linting …/contacts/src/components/Properties/PropertyDateTime.vue:166
@nickvergessen nickvergessen added bug Something isn't working 0. to triage Pending approval or rejection. This issue is pending approval. labels Feb 25, 2020
@skjnldsv
Copy link
Member

skjnldsv commented Feb 25, 2020 •
edited

Yes I saw that, this is coming from the plugin it seems
mysticatea/eslint-plugin-node#207

@skjnldsv skjnldsv mentioned this issue Feb 27, 2020
Closed
@georgehrke
Copy link
Member

Bumping eslint-plugin-node to 11 fixed it for me in Calendar

@skjnldsv
Copy link
Member

skjnldsv commented Mar 2, 2020

@georgehrke no peer conflicts? Are you using @nextcloud/eslint-config ?

@georgehrke
Copy link
Member

georgehrke commented Mar 2, 2020 •
edited

I'm still on eslint-plugin-nextcloud. I had to bump eslint-plugin-node manually, but nothing broke.

Edit: eslint-plugin-nextcloud != eslint-config-Nextcloud, so no

@skjnldsv
Copy link
Member

skjnldsv commented Mar 3, 2020

That is why then :)
Let me see!

This was referenced Mar 3, 2020
Merged
Merged
@skjnldsv
Copy link
Member

skjnldsv commented Mar 3, 2020

@georgehrke same here https://github.com/nextcloud/photos/pull/218/files
But updating to eslint-plugin-node doesn't fix it :(

@skjnldsv skjnldsv removed the 0. to triage Pending approval or rejection. This issue is pending approval. label Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix eslint nextcloud/contacts
3 participants
@nickvergessen @georgehrke @skjnldsv