Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adminmanual): Document data retention and possible issues #11626

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ChristophWurst
Copy link
Member

☑️ Resolves

Backstory: found an instance where entries were deleted from calendarchanges before connected clients had a chance to read the latest changes.

🖼️ Screenshots

image

@ChristophWurst
Copy link
Member Author

/backport to stable28

@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26


php occ config:app:set totalNumberOfSyncTokensToKeep --value=30000

The default is keeping 10,000 entries. This option should be set adequate to the number of users. E.g. on an installation with 5000 active contacts users the system would only keep an average of 10 changes per user. This will lead to premature data deletion and synchronization problems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The default is keeping 10,000 entries. This option should be set adequate to the number of users. E.g. on an installation with 5000 active contacts users the system would only keep an average of 10 changes per user. This will lead to premature data deletion and synchronization problems.
The default is keeping 10,000 entries. This option should be set adequate to the number of users. E.g. on an installation with 5000 active synced addressbooks the system would only keep an average of 10 changes per sync. This will lead to premature data deletion and synchronization problems.

For clarity


php occ config:app:set totalNumberOfSyncTokensToKeep --value=30000

The default is keeping 10,000 entries. This option should be set adequate to the number of users. E.g. on an installation with 5000 active calendar users the system would only keep an average of 10 changes per user. This will lead to premature data deletion and synchronization problems.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The default is keeping 10,000 entries. This option should be set adequate to the number of users. E.g. on an installation with 5000 active calendar users the system would only keep an average of 10 changes per user. This will lead to premature data deletion and synchronization problems.
The default is keeping 10,000 entries. This option should be set adequate to the number of users. E.g. on an installation with 5000 active synced calendars the system would only keep an average of 10 changes per calendar. This will lead to premature data deletion and synchronization problems.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the feat/adminmanual/dav-data-retention branch from fe59317 to bb03c7f Compare March 8, 2024 14:19
Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting data makes it scary


.. versionadded:: 26.0.0

You can configure how long Nextcloud keeps some of the calendar data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can configure how long Nextcloud keeps some of the calendar data.
You can configure how long Nextcloud keeps some of the calendar sync tokens.


.. versionadded:: 26.0.0

You can configure how long Nextcloud keeps some of the contacts data.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can configure how long Nextcloud keeps some of the contacts data.
You can configure how long Nextcloud keeps some of the contacts sync tokens.

@@ -21,6 +21,10 @@ A brief overview of changes:

See for more information: :ref:`email-smtp-config`.

DAV data retention
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
DAV data retention
DAV sync tokens retention

DAV data retention
------------------

A mechanism to clean up old CalDAV and CardDAV data has been added. See :ref:`CalDAV retention <caldav-data-retention>` and :ref:`CardDAV retention <carddav-data-retention>` and make sure it fits your installation size.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
A mechanism to clean up old CalDAV and CardDAV data has been added. See :ref:`CalDAV retention <caldav-data-retention>` and :ref:`CardDAV retention <carddav-data-retention>` and make sure it fits your installation size.
A mechanism to clean up old CalDAV and CardDAV sync tokens has been added. See :ref:`CalDAV retention <caldav-data-retention>` and :ref:`CardDAV retention <carddav-data-retention>` and make sure it fits your installation size.

@susnux susnux modified the milestones: Nextcloud 29, Nextcloud 30 Mar 29, 2024
@susnux
Copy link
Contributor

susnux commented Mar 29, 2024

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document dav app setting totalNumberOfSyncTokensToKeep
3 participants