Add import extension rule

[Pytal]

Warn when file extensions are not used on imports paths with the import/extensions rule, this is to stay up-to-date with the ecosystem e.g. Node.js 14 docs

In future we may want to set this to error

Also see nextcloud-libraries/webpack-vue-config#297

[artonge]

If the best practice is to enforce it, why not do it now?

We can start with a warning and change to an error in a year or so.

[Pytal]

If the best practice is to enforce it, why not do it now?

We can start with a warning and change to an error in a year or so.

Wanted to avoid breaking things by introducing too many changes, so as suggested we can go with a warning instead

[Pytal]

One more review here? not required in this repo though

[raimund-schluessler]

With this rule the line

export { default as richEditor } from './richEditor'

is now invalid and one needs to write

export { default as richEditor } from './richEditor/index.js'

Is this the desired behaviour?

[Pytal]

@raimund-schluessler yes, as with the broader ecosystem, e.g. Node.js 14 docs, all import paths should include the file extension with no special treatment of index.js files excluding package imports as specified by the ignorePackages: true option added in this PR

[raimund-schluessler]

@Pytal Thanks for the background information 👍
Should we maybe release this then in the next time? This is a change which will require quite a bit of manual work and I think it would be nice to not mix it with any more bigger changes in the next release. What do you think?

[Pytal]

@raimund-schluessler fine with me as long as this goes in a major as this is breaking :) @skjnldsv fine with releasing this in the next major?

[skjnldsv]

Yep! 👍 😉

[skjnldsv]

This is a change which will require quite a bit of manual work and I think it would be nice to not mix it with any more bigger changes in the next release. What do you think?

Can this be automated with eslint fix? I haven't tried 🤔

[raimund-schluessler]

This is a change which will require quite a bit of manual work and I think it would be nice to not mix it with any more bigger changes in the next release. What do you think?

Can this be automated with eslint fix? I haven't tried 🤔

I run this rule in nextcloud-libraries/nextcloud-vue#2637 already. No fix is offered and npm run lint:fix doesn't do anything unfortunately. I had to adjust everything manually.

[raimund-schluessler]

So.... Who is going to do the release? 🙂 🙈

[Pytal]

So.... Who is going to do the release? 🙂 🙈

Feel free @raimund-schluessler https://github.com/nextcloud/eslint-config#release-new-version 🚀

[raimund-schluessler]

So.... Who is going to do the release? slightly_smiling_face see_no_evil

Feel free @raimund-schluessler https://github.com/nextcloud/eslint-config#release-new-version rocket

Fine with me. But how is the changelog generated?

[skjnldsv]

Fine with me. But how is the changelog generated?

sometimes manually, sometimes with github_changelog_generator