Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix eslint-plugin-n conflict #421

Merged
merged 1 commit into from Nov 15, 2022
Merged

Fix eslint-plugin-n conflict #421

merged 1 commit into from Nov 15, 2022

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Nov 15, 2022

There are ways to still have 8.1.3 used, but this makes things easier

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: eslint-config-standard@17.0.0-1
npm ERR! Found: eslint-plugin-n@15.5.1
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^15.2.3" from @nextcloud/eslint-config@8.1.3
npm ERR!   node_modules/@nextcloud/eslint-config
npm ERR!     dev @nextcloud/eslint-config@"^8.1.3" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer eslint-plugin-n@"^14.0.0" from eslint-config-standard@17.0.0-1
npm ERR! node_modules/eslint-config-standard
npm ERR!   peer eslint-config-standard@"^17.0.0-0" from @nextcloud/eslint-config@8.1.3
npm ERR!   node_modules/@nextcloud/eslint-config
npm ERR!     dev @nextcloud/eslint-config@"^8.1.3" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: eslint-plugin-n@14.0.0
npm ERR! node_modules/eslint-plugin-n
npm ERR!   peer eslint-plugin-n@"^14.0.0" from eslint-config-standard@17.0.0-1
npm ERR!   node_modules/eslint-config-standard
npm ERR!     peer eslint-config-standard@"^17.0.0-0" from @nextcloud/eslint-config@8.1.3
npm ERR!     node_modules/@nextcloud/eslint-config
npm ERR!       dev @nextcloud/eslint-config@"^8.1.3" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /home/admin/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/admin/.npm/_logs/2022-11-15T15_46_52_901Z-debug-0.log

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv self-assigned this Nov 15, 2022
@skjnldsv skjnldsv added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 15, 2022
@skjnldsv skjnldsv requested review from a team, PVince81, artonge and szaimen and removed request for a team November 15, 2022 15:49
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you bump all of them to their latest version?

Anyway, trusting you that it works 🙈

package.json Show resolved Hide resolved
@skjnldsv skjnldsv merged commit 6eb8958 into master Nov 15, 2022
@skjnldsv skjnldsv deleted the fix/eslint-deps branch November 15, 2022 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants