Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to change the location of the Maps default folder #1078

Open
louim-lbs opened this issue Jun 22, 2023 · 2 comments
Open

Ability to change the location of the Maps default folder #1078

louim-lbs opened this issue Jun 22, 2023 · 2 comments
Labels
0. Needs triage enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in.

Comments

@louim-lbs
Copy link

How to use GitHub

  • Please use the 馃憤 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Is your feature request related to a problem? Please describe.
I would like to be able to change the location of the Maps default folder, to have a clearer folder list at root.

Describe the solution you'd like
Like in Talk, or Calendar apps.

@tacruc tacruc added the good first issue Small tasks with clear documentation about how and in which place you need to fix things in. label Jul 4, 2023
@nougatbyte
Copy link

I think about taking a shot at this. Could someone please summarize what one roughly has to do?

From my first looks I would need to

  • Find all occurences of the /Maps path and replace it with a variable or function
  • Find all mentions of /Maps in the translations and replace them
  • Implement a configuration or .env variable (This is where I'm least sure what the intended way in Nextcloud would be)

@tacruc
Copy link
Collaborator

tacruc commented Mar 11, 2024

First of all thanks for your initiative. If you have any questions or problems feel free to ask for more help. I give my best to give you some hints. But I'm on the phone write now and looking up the relavent links is cumbersome, so excuse me if some don't work.

First of all you need to decide if the variable should be user depended or the same for all users on the server.

Then You can use an app config variable (for all users) or userValue for a user depended value with

https://stable27--nextcloud-server.netlify.app/classes/ocp-iconfig#method_setAppValue

https://stable27--nextcloud-server.netlify.app/classes/ocp-iconfig#method_getAppValue

IConfig additionally has the getAppValue method. Probably you should provide a default value in the getAppValue to prevent issues when the variable is not set, alternatively you must write a transaction setting the value when installing the update.

Then you can use the occ command https://docs.nextcloud.com/server/latest/admin_manual/configuration_server/occ_command.html#config-commands-label
To set the values. Probably the user:setting can edit the user values.

Last you could extend the user and/or admin setting GUI to have a GUI for configuration.

Manually updating the translation files is not needed, they are generated by transifex. Updating the translation has to happen there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage enhancement good first issue Small tasks with clear documentation about how and in which place you need to fix things in.
Projects
None yet
Development

No branches or pull requests

3 participants