fix: Initialize the bus only if required #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the bus is initialized when the file is imported and as the bus requires the window to be present it fails for e.g. testing without a DOM environment. To fix this the bus is now initialized on the first usage and while the window is not present only a stub is used. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
skjnldsv
reviewed
Mar 16, 2023
skjnldsv
approved these changes
Mar 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the bus is initialized when the file is imported and as the bus requires the window to be present it fails for e.g. testing without a DOM environment.
To fix this the bus is now initialized on the first usage and while the window is not present only a stub is used.