Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Do not export the declaration of window.OC #667

Merged
merged 1 commit into from Jun 14, 2023
Merged

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jun 14, 2023

See nextcloud-libraries/nextcloud-router#485

It makes testing on server difficult

@skjnldsv skjnldsv self-assigned this Jun 14, 2023
@skjnldsv skjnldsv requested a review from susnux June 14, 2023 09:00
@skjnldsv skjnldsv added dependencies Pull requests that update a dependency file 3. to review labels Jun 14, 2023
@skjnldsv skjnldsv force-pushed the fix/oc-win branch 2 times, most recently from 408acb3 to 591ece9 Compare June 14, 2023 09:16
@skjnldsv skjnldsv requested a review from artonge June 14, 2023 09:17
@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (df1a4f9) 100.00% compared to head (c5bbd90) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #667   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          242       242           
  Branches        68        68           
=========================================
  Hits           242       242           
Impacted Files Coverage Δ
lib/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@ChristophWurst ChristophWurst merged commit 97da8b8 into master Jun 14, 2023
11 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/oc-win branch June 14, 2023 09:54
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants