Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fileid definition and fallback #681

Merged
merged 1 commit into from Jul 4, 2023
Merged

fix: fileid definition and fallback #681

merged 1 commit into from Jul 4, 2023

Conversation

skjnldsv
Copy link
Contributor

@skjnldsv skjnldsv commented Jul 4, 2023

The id was never used before.
Now we fixed it!

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added the bug Something isn't working label Jul 4, 2023
@skjnldsv skjnldsv self-assigned this Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4629f39) 100.00% compared to head (f5dd53f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #681   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          242       242           
  Branches        68        69    +1     
=========================================
  Hits           242       242           
Impacted Files Coverage Δ
lib/files/node.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@skjnldsv skjnldsv merged commit 07cec4a into master Jul 4, 2023
9 checks passed
@skjnldsv skjnldsv deleted the fix/fileid branch July 4, 2023 10:56
@skjnldsv skjnldsv mentioned this pull request Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant