[stable7] feat: Add slot for description of NcEmptyContent
#4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
added
enhancement
backportbot-nextcloud
bot
requested review from
max-nextcloud,
raimund-schluessler and
susnux
|
Required also for older versions running 7.x |
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
susnux
force-pushed
the
backport/3895/stable7
branch
from
ed531d3
to
3ad8745
Compare
susnux
approved these changes
May 31, 2023
ShGKme
approved these changes
Jun 6, 2023
Comment on lines
160
to
162
| hasDescription() { | ||
| return this.description !== '' | ||
| return this.description !== '' || this.$slots.description?.[0] | ||
| }, |
There was a problem hiding this comment.
Note: this is not well compatible with Vue 3 (by design). Isn't this.$slots.description enough to check if the description slot was passed?
There was a problem hiding this comment.
As stable7 will not see vue3 (I guess) we should discuss this for the version on the master branch.
Nevertheless this is required to keep the behavior the same, as an empty slot = empty property should not show the description nodes.
There was a problem hiding this comment.
Nevertheless this is required to keep the behavior the same, as an empty slot = empty property should not show the description nodes.
By empty slot do you mean this usage:
<NcEmptyContent>
<!-- nothing -->
</NcEmptyContent>or this
<NcEmptyContent>
<template #description></template>
</NcEmptyContent>?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #3895