Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/remove margin below message in widget item #4297

Merged
merged 1 commit into from Jul 4, 2023
Merged

Fix/remove margin below message in widget item #4297

merged 1 commit into from Jul 4, 2023

Conversation

JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter added the 3. to review Waiting for reviews label Jul 3, 2023
@JuliaKirschenheuter JuliaKirschenheuter self-assigned this Jul 3, 2023
@JuliaKirschenheuter JuliaKirschenheuter changed the base branch from master to stable7 July 3, 2023 13:20
@JuliaKirschenheuter
Copy link
Contributor Author

how could i "backport" to stable8 which is not exist yet?

@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Jul 3, 2023
Closed
6 tasks
@JuliaKirschenheuter
Copy link
Contributor Author

My commit have Signed-off-by. Why DCO is failing?

@artonge artonge requested a review from skjnldsv July 4, 2023 07:48
@raimund-schluessler
Copy link
Contributor

how could i "backport" to stable8 which is not exist yet?

You should send the PR against master and then backport to stable7. Our just send the same PR to master, now that you have this one here already.

@JuliaKirschenheuter
Copy link
Contributor Author

You should send the PR against master and then backport to stable7. Our just send the same PR to master, now that you have this one here already.

Thanks Raimund! I would do it like "usual" but can't wait until stable8 will be ready, this will took some time. But will create a second PR against master.

@JuliaKirschenheuter
Remove margin below widget item
5bf0f7c 
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/remove-margin-below-message-in-widget-item branch from d2592cf to 5bf0f7c Compare July 4, 2023 09:11
@JuliaKirschenheuter JuliaKirschenheuter merged commit 91787fd into stable7 Jul 4, 2023
16 checks passed
@JuliaKirschenheuter JuliaKirschenheuter deleted the fix/remove-margin-below-message-in-widget-item branch July 4, 2023 09:27
@skjnldsv skjnldsv mentioned this pull request Jul 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raimund-schluessler raimund-schluessler raimund-schluessler approved these changes

@artonge artonge artonge approved these changes

@susnux susnux Awaiting requested review from susnux

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

@Pytal Pytal Awaiting requested review from Pytal

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@JuliaKirschenheuter JuliaKirschenheuter

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
3 participants
@JuliaKirschenheuter @raimund-schluessler @artonge