Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.1.4.3/3.4 - "Details" section / "Share" menu - Both the label and note do not meet the contrast requirements for text. (2) #36954

Closed
4 tasks done
AndyScherzinger opened this issue Mar 1, 2023 · 4 comments
Assignees
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility design Design, UI, UX, etc.
Milestone

Comments

@AndyScherzinger AndyScherzinger added 1. to develop Accepted and waiting to be taken care of accessibility design Design, UI, UX, etc. labels Mar 1, 2023
@Pytal Pytal self-assigned this Apr 29, 2023
@Pytal Pytal added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Apr 29, 2023
@Pytal
Copy link
Member

Pytal commented Apr 29, 2023

On master

  • Share label
  • Share note

@Pytal
Copy link
Member

Pytal commented May 4, 2023

NcAction* components are using opacity to indicate focus/hover

The share note is using NcActionTextEditable

To ensure we are using contrast-verified colors we should stop using opacity in NcAction* components and go with one of 2 options below

  1. Replace $opacity_normal: .7--color-text-maxcontrast and $opacity_full: 1--color-main-text
    image
  2. Set the base color to --color-main-text and like the tertiary NcButton:
    image
    only use the background color, --color-background-hover, alongside input-specific colors, e.g. --color-primary-element for text field borders, to indicate focus/hover
    image

Option 2 seems better to me as all options have high readability regardless of focus/hover

NcActionTextEditable examples

Option 1 Option 2
image image

This change will affect all NcAction* components, not just NcActionTextEditable, to maintain consistency

Which option should we go for @jancborchardt?

@Pytal
Copy link
Member

Pytal commented May 4, 2023

👆 Any option you'd lean towards @nimishavijay?

@nimishavijay
Copy link
Member

Agreed, option 2 sounds like it has better readability overall :) Here's how it would look like in Mail and Files.

@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 6, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 16, 2023
@Pytal Pytal closed this as completed May 16, 2023
@AndyScherzinger AndyScherzinger added this to the Nextcloud 27 milestone May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility design Design, UI, UX, etc.
Projects
None yet
Development

No branches or pull requests

3 participants