New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITV] 9.3.3.2/3.3 - Comment section: The input fields for creating and editing comments lack visual labels. (2) #37087
[BITV] 9.3.3.2/3.3 - Comment section: The input fields for creating and editing comments lack visual labels. (2) #37087
Comments
That is an ugly one. Just upgraded to NC v27.0.1 and checked with german and english. Can confirm the issue @dregad described. @AndyScherzinger are that two issues or one? |
This issue would resolve what has been commented on this issue... If the placeholder text gets moved below the input field than the issue with the length is automatically solved. |
@ShGKme maybe a starter issue for you? |
@jancborchardt what should be used as a placeholder when the text is moved below the field as a description? |
Is that correct that |
What about:
|
@ShGKme |
Can someone add an image showing how the solution will look like? @susnux |
|
I think here we should use the same label that we've added to text fields and cut it short to "Write a comment" for its text. I would avoid this long suggestion altogether in such small inputs. It uses a lot of space and becomes redundant the moment any given user first learns about the functionality. This belongs in the documentation or in an informative tooltip that pops up the first time you use the feature. Going forward there will be more and more things that one will be able to do with an input field, just as important or more important than emojis and mentions depending on the context. We cannot write a docs page in there :) |
We can make the default description short and initial size of the text field 2 lines. For example, in this case shorter to:
But it still can be too long to be 1-line in some languages and small screens.
I'd avoid this approach as too complex for that. If we don't want to show the tooltip each time user re-login, we need to store it in the database, grab on each page rendering with initial state...
Then we need to mention it in the all places with rich contenteditable. Currently there is no documentation about commenting files at all in the user documentation. I think, UI should be understandable without reading all the documentation, especially speaking about accessibility. As an alternative I may propose adding a small question mark button that opens a tooltip with any descriptions and/or links. But it must be 44px anyway... Still I have no idea where to put it. Current alternative: nextcloud-libraries/nextcloud-vue#4408 |
Option 1: add visible description block
PR: nextcloud-libraries/nextcloud-vue#4482 Option 2: remove instructions at all (move to the user documentation)PR: nextcloud-libraries/nextcloud-vue#4408
Option 3: add one-time instruction
Option 4: add a help button to show instructions
(design from paint) |
see also #37091
The important note "Write message, use "@" to mention someone, use ":" for emoji autocompletion …," is only available as a placeholder element and should ideally be placed as visual text below the field linked to it via aria-describedby attribute.
Details
https://report.bitvtest.de/default-en/d63601ac-cb34-4645-8256-66bec78964a0.html#checkpoint-9f92015c98-v3-n3
The text was updated successfully, but these errors were encountered: