Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BITV] 9.4.1.2/3.7 - In the breadcrumb navigation, there are "aria-label" attributes on "li" elements, which is not allowed, such as aria-label="Go to the "/" directory". (2) #41895

Closed
JuliaKirschenheuter opened this issue Nov 29, 2023 · 13 comments · Fixed by #42950
Assignees
Labels

Comments

@JuliaKirschenheuter
Copy link
Contributor Author

Waiting for nextcloud-libraries/nextcloud-vue#4918 to be released

@JuliaKirschenheuter
Copy link
Contributor Author

@szaimen not resolved?

@szaimen
Copy link
Contributor

szaimen commented Jan 12, 2024

@szaimen not resolved?

I may have moved it by mistake...

@szaimen
Copy link
Contributor

szaimen commented Jan 18, 2024

We have this here now:
image
Is this the correct implementation @susnux @ShGKme @emoral435 @Pytal @JuliaKirschenheuter ?

@JuliaKirschenheuter
Copy link
Contributor Author

semantically it is correct but aria-label seems to be not translated. @emoral435 what was the last stand 🤔?

@emoral435
Copy link
Contributor

emoral435 commented Jan 18, 2024

image

@JuliaKirschenheuter

This is what we came up as our decision (copied and pasted it from my messages with skjnldsv - won't tag him because I do not want to bog him down with another ping, LOL).

So as far as implementation, it is correct, however, upon testing right now, it seems as if the aria label for the home section seems to be untranslated, probably due to it being not a component that we made. It is a component supplied by Vue itself. Will be correcting this!

@szaimen
Copy link
Contributor

szaimen commented Jan 26, 2024

Seems like aria-label="Home" is still not translated?
image

@szaimen szaimen reopened this Jan 26, 2024
@ShGKme
Copy link
Contributor

ShGKme commented Jan 26, 2024

Seems like aria-label="Home" is still not translated?

Is it informal or formal German?

@szaimen
Copy link
Contributor

szaimen commented Jan 26, 2024

formal German

@emoral435
Copy link
Contributor

@ShGKme Would you be able to handle the translations here? I unfortunately do not know formal German. However, I also would not mind doing it myself, I am just now familiar with how our translation system works. A pointer in the right direction would help me lots :)

@ShGKme
Copy link
Contributor

ShGKme commented Jan 26, 2024

That was unexpected, but this string in exactly this place was intentionally translated as "Home" in Transifex.

From a little research, this is indeed a common way to translate "Home" in a context of "Home directory".

So everything is fine here.

cc @susnux for a native speaker

@susnux
Copy link
Contributor

susnux commented Jan 27, 2024

Yes quite common, but could also be "Start" or "Startverzeichnis". cc @rakekniven

@szaimen
Copy link
Contributor

szaimen commented Feb 2, 2024

i guess this can be closed then...

@szaimen szaimen closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants