Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Mentioning users in comment doesn't render user names #43386

Closed
4 of 8 tasks
st3iny opened this issue Feb 6, 2024 · 2 comments
Closed
4 of 8 tasks

[Bug]: Mentioning users in comment doesn't render user names #43386

st3iny opened this issue Feb 6, 2024 · 2 comments
Labels
2. developing Work in progress 29-feedback bug feature: comments feature: file sidebar Related to the file sidebar component

Comments

@st3iny
Copy link
Member

st3iny commented Feb 6, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

No user names are rendered when mentioning users in the comment rich text editor in files.

Screenshot_20240206_111233

Steps to reproduce

  1. Open the sidebar of a file.
  2. Start typing a comment and mention someone by typing @user....
  3. Some results are shown but only the avatar is rendered.

Expected behavior

The avatar and user name should be rendered for each autocomplete result.

It turns out that the OCS endpoint returns an object like: { "label": "user..." }
But NcAutoCompleteResult expects: { "title": "user..." }

Installation method

None

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

Can be reproduced on c.nc.c.

@st3iny st3iny added bug 2. developing Work in progress labels Feb 6, 2024
@st3iny st3iny self-assigned this Feb 6, 2024
@st3iny st3iny added feature: comments feature: file sidebar Related to the file sidebar component labels Feb 6, 2024
@st3iny
Copy link
Member Author

st3iny commented Feb 6, 2024

Rendering of inserted mentions is also broken in a similar way:

grafik

@st3iny
Copy link
Member Author

st3iny commented Feb 6, 2024

@st3iny st3iny closed this as completed Feb 6, 2024
@st3iny st3iny removed their assignment Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress 29-feedback bug feature: comments feature: file sidebar Related to the file sidebar component
Projects
None yet
Development

No branches or pull requests

2 participants