Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer click "outside" to close modals #10958

Closed
nickvergessen opened this issue Nov 21, 2023 · 2 comments
Closed

Can no longer click "outside" to close modals #10958

nickvergessen opened this issue Nov 21, 2023 · 2 comments

Comments

@nickvergessen
Copy link
Member

How to use GitHub

  • Please use the 👍 reaction to show that you are affected by the same issue.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Happens for

  1. Talk settings
  2. Conversation settings
  3. Selecting a file from Nextcloud (so the file picker)
  4. Selecting conversation avatar from Nextcloud

Still works for

  1. Participants permissions editor
  2. Conversation creation
  3. Open conversation list
  4. Forwarding a message
  5. Creating a poll
@DorraJaouad
Copy link
Contributor

Talk settings
Conversation settings

These are NcAppSettingsDialog , and ability to close by outside click is not supported. I am not sure if it is expected or not . If not, we can put it in upstream.

Selecting a file from Nextcloud (so the file picker)

File picker from the menu works fine
image

But I can see errors when getting it from / in input
image
Probably affecting its closure.

Selecting conversation avatar from Nextcloud

It closes by outside click for me.

@Antreesy
Copy link
Contributor

Antreesy commented Jan 12, 2024

Upstreamed for component in general and NcAppSettingsDialog: nextcloud-libraries/nextcloud-vue#5062
Upstreamed issue for FilePicker is here: nextcloud-libraries/nextcloud-dialogs#1168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants