Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callout box with type info changes color with theme #4161

Closed
mejo- opened this issue May 9, 2023 · 3 comments · Fixed by #4301
Closed

Callout box with type info changes color with theme #4161

mejo- opened this issue May 9, 2023 · 3 comments · Fixed by #4301
Assignees
Labels
1. to develop bug Something isn't working ux

Comments

@mejo-
Copy link
Member

mejo- commented May 9, 2023

Describe the bug
The border color of callout boxes with type info currently is set to var(--color-primary-element). This variable can be changed in custom themes.

Instead, we should probably hardcode it to #006aa3 for now and use var(--color-info) once it got introduced.

See nextcloud-libraries/nextcloud-vue#4063 (comment).

@mejo-
Copy link
Member Author

mejo- commented May 12, 2023

nextcloud/server#38205 introduces var(--color-info). Once it got merged, we could switch to it but should still set #006aa3 as fallback for backwards-compatibility.

@max-nextcloud
Copy link
Collaborator

I'd be tempted to just migrate to using Nextcloud vues note card and not backport this.

But maybe that's two steps indeed. A fix with a hard coded default that can be backported and then the migration.

@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Jun 16, 2023

We are using Nextcloud vue 7 since stable25. So maybe we could move to using the component right away to fix this and backport all the way to stable25 with minor version bumps of Nextcloud vue.

update: the addition in Nextcloud vue still requires Nextcloud 27. So that is not an option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working ux
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants