[BITV] 9.1.4.1/3.1 - Styling menubar - For many elements like "B" and "I", selected styles are visually marked by a pale blue background (1,2:1 to white) and remain below the contrast ratio of 3:1 that is needed to indicate the state visually. (2)

[JuliaKirschenheuter]

https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-45ae33ca9f-v3-n1

9.1.4.1/11.1 - https://report.bitvtest.de/default-en/cbedb5ef-4815-4cba-a83d-995599c178c3.html#checkpoint-45ae33ca9f-v11-n1

[susnux]

Probably it would be enough to use the pressed property of NcButton which will enforce the contrast

[juliushaertl]

Original reference #3860 (comment)

@nextcloud/designers Can someone please have a look at #3860 (comment) for that?

While I get the pressed state fixes the accessibility concern, i find that quite odd to have a kindof primary style for all those buttons.

[susnux]

See also this PR: nextcloud-libraries/nextcloud-vue#4344

[jancborchardt]

i find that quite odd to have a kindof primary style for all those buttons.

@juliushaertl unfortunately there are not a lot of alternatives:

• Current one does not have enough contrast
• Having a dot below (or similar element) we had before, it looks nice but is non-standard and also there’s simply no space for it like e.g. in Office.
• Adding a border would make everything very busy and introduce yet another style, also conflicting with the focus style.

Last time we talked about this we saw that Apple also uses the "primary" style, and it’s quite fine. In Text at least it works since there is no primary button. But indeed I am unsure about Collectives where there is a primary button too.

iOS Notes	Apple Pages sidebar

[juliushaertl]

Ok, then let's go for the pressed button style.

[max-nextcloud]

Okay, cool. Looks like the pressed button style is available since 7.12.2 and stable26 is on 7.12.7 - so even if we want to backport this we should be fine.

[juliushaertl]

We'd only "need" this for 28 but if we can fix this also for previous ones even better 🎉

[max-nextcloud]

I'll only backport to stable28 as this is quite a visible UI change and quite a bit of the ui changes with 28 while hardly any other ui changes will happen with 27 minor releases.