Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change method name in nextcord.Webhook #1032

Open
Gangsta-Muffin opened this issue Apr 4, 2023 · 1 comment
Open

Change method name in nextcord.Webhook #1032

Gangsta-Muffin opened this issue Apr 4, 2023 · 1 comment
Labels
3.0 The issue/PR should go for the 3.0 release s: planned Status: the issue is planned to be worked on t: refactor Type: refactor - this is a code change but does not fix a bug/add features

Comments

@Gangsta-Muffin
Copy link

Gangsta-Muffin commented Apr 4, 2023

This issue is regarding the following method:

nextcord.Webhook.fetch()

This function is a coroutine.

Fetches the current webhook.

This could be used to get a full webhook from a partial webhook.

New in version 2.0.

Suggestion names
full_webhook()
fetch_webhook()
...

This issue is designed to earmark the change for future purposes. This issue should stay upen until a semver bump (direct orders from the game):
https://discord.com/channels/881118111967883295/881124672056467456/1092908062131630210

@Skelmis Skelmis added s: planned Status: the issue is planned to be worked on t: refactor Type: refactor - this is a code change but does not fix a bug/add features 3.0 The issue/PR should go for the 3.0 release labels Apr 9, 2023
@EmreTech
Copy link
Collaborator

I wouldn't include "webhook" in the name because it's pretty self-explanatory that a method named fetch in a class named Webhook fetches the webhook from Discord. I would rename the method to something like fetch_full.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 The issue/PR should go for the 3.0 release s: planned Status: the issue is planned to be worked on t: refactor Type: refactor - this is a code change but does not fix a bug/add features
Projects
None yet
Development

No branches or pull requests

3 participants