-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: move listeners to the main library #917
Open
EmreTech
wants to merge
10
commits into
nextcord:master
Choose a base branch
from
EmreTech:feat/add-listeners-to-client
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmreTech
added
p: low
Priority: low - not important to be worked on
s: awaiting review
Status: the issue or PR is awaiting reviews
t: refactor
Type: refactor - this is a code change but does not fix a bug/add features
labels
Nov 23, 2022
Skelmis
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Untested, lgtm
MaskDuck
suggested changes
Jan 23, 2023
spifory
suggested changes
Jun 27, 2023
Co-authored-by: spifory <luvuyosilubane50@gmail.com>
ooliver1
reviewed
Dec 9, 2023
ooliver1
reviewed
Mar 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine. Test code:
import os
from dotenv import load_dotenv
from nextcord import Client, Intents, Message
load_dotenv()
client = Client(intents=Intents(guilds=True, guild_messages=True, message_content=True))
@client.listen()
async def on_ready():
print("Bot is ready")
async def on_message(message: Message):
if message.content == "ping":
await message.channel.send("pong")
client.remove_listener(on_message)
client.add_listener(on_message)
client.run(os.environ["TOKEN"])
ooliver1
added
s: in progress
Status: the issue or PR is in development/progress
3.0
The issue/PR should go for the 3.0 release
and removed
s: awaiting review
Status: the issue or PR is awaiting reviews
labels
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3.0
The issue/PR should go for the 3.0 release
p: low
Priority: low - not important to be worked on
s: in progress
Status: the issue or PR is in development/progress
t: refactor
Type: refactor - this is a code change but does not fix a bug/add features
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves listeners from
commands.Bot
tonextcord.Client
. Closes #892.Checklist
task pyright
and fixed the relevant issues.