Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove focus border (outline) on safari #174

Closed
shaynlink opened this issue Jan 28, 2022 · 7 comments · Fixed by #511 or #512
Closed

Remove focus border (outline) on safari #174

shaynlink opened this issue Jan 28, 2022 · 7 comments · Fixed by #511 or #512
Labels
✨ Type: Enhancement New enhancement on existing codebase

Comments

@shaynlink
Copy link

First sorry for my English 😅

Isn't really a bug, focus border (aka outline) is a default css in all navigator, it's not working on chrome but it's on safari.

Why remove outline ?
What is outline ? outline is a default css style active when a div (or other component) is focused, for indicate to user that this component is used.
But when outline is active, on toggle you have an unpleasant feeling and you want to click outside the component for remove outline (please say me I'm not alone 😟).
So this feeling is not good for user experience, because for one click component like toggle you need click two time (one time for interact with component and one time outside component for remove outline).
You can keep outline for multi interact component like input, but isn't good for one click component like toggle, button or for parent/global component like card.

Steps to reproduce

  1. Click on toggle
  2. See outline

Expected behaviour
Outline not apparead

Screenshots
image
image

Environment / Context

  • Desktop (I don't have iPhone, so idk for safari mobile)
  • Operating System: MacOS 12.2
  • Browser and version: Safari stable 15.3
  • Device: MacBook Pro 2020 M1
@mariusflorescu
Copy link
Contributor

@shaynlink thank you for reporting !

@jrgarciadev jrgarciadev added ✨ Type: Enhancement New enhancement on existing codebase type:docs-src labels Jan 29, 2022
@Joaovsa7
Copy link

Isn't an outline good for accessibility? I think that we should consider this point before removing it.

What do you think about it?

@Perni1984
Copy link

yes it is - better to style the outline in a proper way than to remove it.

https://www.a11yproject.com/posts/never-remove-css-outlines/

@calebpanza
Copy link

I have a card based design that I would prefer to not have a focus state on at all. Is there any way to remove it, currently?

@stale
Copy link

stale bot commented Apr 6, 2022

Hello 👋, to help manage issues we automatically close stale issues. This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention? > This issue will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the type: stale label Apr 6, 2022
@stale
Copy link

stale bot commented Apr 9, 2022

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Apr 9, 2022
@jrgarciadev jrgarciadev reopened this Apr 9, 2022
@stale stale bot removed the type: stale label Apr 9, 2022
@stale stale bot removed the type: stale label Apr 9, 2022
@Perni1984
Copy link

@calebpanza you should be able to use the css prop to overwrite any styling you don't need (https://stitches.dev/docs/overriding-styles#the-css-prop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Type: Enhancement New enhancement on existing codebase
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants