Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme:title): add selector property #1487

Merged
merged 3 commits into from
Aug 14, 2022
Merged

feat(theme:title): add selector property #1487

merged 3 commits into from
Aug 14, 2022

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented May 29, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Sorry, something went wrong.

cipchk added 2 commits May 29, 2022 19:20

Verified

This commit was signed with the committer’s verified signature.
Letiste Léo Salé
@ng-alain-bot
Copy link
Contributor

ng-alain-bot commented May 29, 2022

Preview is ready!

@codecov
Copy link

codecov bot commented May 29, 2022

Codecov Report

Merging #1487 (bc9da75) into master (d8efc02) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1487   +/-   ##
=======================================
  Coverage   95.37%   95.38%           
=======================================
  Files         270      270           
  Lines        8436     8443    +7     
  Branches     1575     1575           
=======================================
+ Hits         8046     8053    +7     
  Misses        300      300           
  Partials       90       90           
Impacted Files Coverage Δ
packages/theme/src/services/title/title.service.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8efc02...bc9da75. Read the comment docs.

@cipchk cipchk merged commit b15f35f into master Aug 14, 2022
@cipchk cipchk deleted the issues-2231 branch August 27, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: TitleService
2 participants